[BUG] Zombie Eventday: Infinite ammo feature is bugged

[azalty]

Describe the bug

It will only give one bullet to the terrorist instead of giving an entire magasine.

Environment

• Current SourceMod version: 1.10 (?)
• Current Metamod: Source snapshot version: N/A
• Current MyJailBreak version: latest dev build + https://github.com/rlevet/MyJailbreak/releases/tag/v2

Additional context

sv_infinite_ammo 2 is probably not a solution because it will also give nades, though we can try to remove nades from players

[azalty]

hmm, there seems to be a problem since this event actually use sv_infinite_ammo 2

what I think: back in the days, map makers spawned weapons with the ammo attribute set to 1 Nowadays, it gives full ammo + 1 bullet, which for some reason is counted separately from the others sv_infinite_ammo 2 could instantly give back that 1 bullet instead of full ammo

Fix idea:

• Use GivePlayerAmmo() to give max ammo to clients, with a timer that reapeats every 2s. This way we'll get rid of sv_infinite_ammo 2 which also give back nades or
• Use GivePlayerAmmo() to give max ammo to clients on weapon equip only. Keep using sv_infinite_ammo 2.

Check https://forums.alliedmods.net/showthread.php?t=260445