shane-kercheval / oo-learning

Python machine learning library based on Object Oriented design principles; the goal is to allow users to quickly explore data and search for top machine learning algorithm candidates for a given dataset
MIT License
1 stars 0 forks source link

PCATransformer.get_pca_plot() hardcode number of components on x-axis #42

Closed shane-kercheval closed 6 years ago

shane-kercheval commented 6 years ago

change range(1, 8) to range(1, len(pca_transformer.cumulative_explained_variance) + 1)

also, rename get_pca_plot to plot_cumulative_variance