shane-tomlinson / browserid-wordpress

Wordpress plugin that adds Persona authentication
23 stars 16 forks source link

Add ability to set the background color of the signin button #34

Closed shane-tomlinson closed 11 years ago

shane-tomlinson commented 11 years ago

From https://github.com/shane-tomlinson/browserid-wordpress/issues/32#issuecomment-20567252

Thanks @KryDos!

krydos commented 11 years ago

Hello. So, what I have...

I created the three inputs for change color of button. They works fine and they works on real time. screenshot at 2013-07-09 21 02 14

screenshot at 2013-07-09 21 03 19

Looks nice I guess. But. With jQuery or JS I can't change the background of left part of button( with "person icon" ) because there uses ":before" selector. Jquery don't have this selector :( And "person icon" this is image. I can't change color for this image too.

So, I can't change the one of the part of button and this is very bad. What's the point if I can change the right part of button but can't change color of the left part of button?

I think changing color of the button is the bad idea. Please forgive me.

shane-tomlinson commented 11 years ago

@KryDos - you are correct, the CSS to draw those buttons is pretty heavy. I have added the ability to to select between one of 3 basic styles, a blue, black, and orange. We can add more to the CSS to give more variety, though making a widget to handle all the gradients, :before, and :after selectors will be pretty heavy.