search

shane-tomlinson / browserid-wordpress

Wordpress plugin that adds Persona authentication
23 stars 16 forks source link

A Persona button is not shown for comments. #38

Closed MagicFab closed 11 years ago

MagicFab commented 11 years ago

Using WordPress 3.5.2.

I tested authentication for comments posting with the stable and dev versions, the Persona button doesn't show up with the dev version of the plugin, even if it's enabled in the options.

shane-tomlinson commented 11 years ago

@MagicFab - Thanks for the report! So that I wasn't interfering with a site's ability to style the comment button, I removed the Persona button and attach the Persona popup to the normal "Post comment" button. Does the "Post comment" button bring up the Persona dialog for you?

MagicFab commented 11 years ago

That would make sense, although no, in my tests it didn't.

shane-tomlinson commented 11 years ago

@MagicFab - can you try it on my site to see if it works for you? Note, you MUST type text into the input box for the Persona dialog to show. Maybe I should not disable the button?

https://shanetomlinson.com/2013/taking-over-as-maintainer-of-the-browserid-wordpress-plugin/

MagicFab commented 11 years ago

It does work on your site. I think just like the admin login, this should be an option "require Persona-only auth for comments". It also should be visibly different/optional if it's not the only requirement.

shane-tomlinson commented 11 years ago

Thanks for reporting this @MagicFab. I have disabled the check to see if a comment has text before opening the Persona dialog.