admin page should verify fields before submitting.

shane-tomlinson / browserid-wordpress

Wordpress plugin that adds Persona authentication

23 stars 16 forks source link

admin page should verify fields before submitting. #49

Closed shane-tomlinson closed 11 years ago

pdehaan commented 11 years ago

I specified an invalid color (salmon) and am now locked out of the admin since i disabled non-Persona logins.

mozilla_persona__a_better_way_to_sign_in

Similarly, if you specify a space for the login button label, it passes whatever empty string check currently exists. We should probably trim the string before checking the string length, or else specify a min-height/min-width on the button using CSS, but that is probably less desirable.

persona_sample_blog__log_in

shane-tomlinson commented 11 years ago

All fields are now verified.