shane-tomlinson / browserid-wordpress

Wordpress plugin that adds Persona authentication
23 stars 16 forks source link

Unable to logout from Admin or Widget #51

Closed johngruen closed 11 years ago

johngruen commented 11 years ago

Possibly the same bug as #25, but adding widget logout failure. Tested in v.45 on WP 3.52 running on MAMP

csuciu commented 11 years ago

I'm not able to logout after changing any of the settings in Mozilla Persona. The logout button becomes unresponsive. If I Deactivate/Activate the plugin, the changes made in settings are cleared and I can logout Env: v.45 and WP 3.52 running on LAMP

shane-tomlinson commented 11 years ago

@csuciu - do you see any errors in the browser's Javascript console?

csuciu commented 11 years ago

@shane-tomlinson - TypeError: navigator.id is null @ http://localhost/wordpress/wp-content/plugins/browserid-wordpress-master/browserid.js?ver=3.5.2:43

The issue only reproduces in production. If I switch to stage the logout works as expected

shane-tomlinson commented 11 years ago

@csuciu thanks - is the call to https://login.persona.org/include.js being made? Are there any 404s?

csuciu commented 11 years ago

@shane-tomlinson - Didn't see the call being made and there are no 404s

shane-tomlinson commented 11 years ago

@csuciu - thanks for that. Looking now.

shane-tomlinson commented 11 years ago

@csuciu - I was eventually able to reproduce this by removing the value of the persona_source option. Can you give the updated code a go and see if this is still a problem?