search

shane-tomlinson / browserid-wordpress

Wordpress plugin that adds Persona authentication
23 stars 16 forks source link

strict errors on admin page #81

Closed shane-tomlinson closed 10 years ago

shane-tomlinson commented 11 years ago

As reported by Soren in https://shanetomlinson.com/2013/persona-browserid-wordpress-plugin-46/comment-page-1/#comment-695

Strict Standards: Declaration of MozillaPersonaTextOption::Validate() should be compatible with MozillaPersonaOption::Validate($value, $options) in /var/www/clients/client2/web18/web/wp-content/plugins/browserid/lib/browserid-options.php on line 219

Strict Standards: Declaration of MozillaPersonaCheckboxOption::Validate() should be compatible with MozillaPersonaOption::Validate($value, $options) in /var/www/clients/client2/web18/web/wp-content/plugins/browserid/lib/browserid-options.php on line 268

Strict Standards: Declaration of MozillaPersonaTermsOfService::Validate() should be compatible with MozillaPersonaOption::Validate($value, $options) in /var/www/clients/client2/web18/web/wp-content/plugins/browserid/lib/browserid-options.php on line 364

Strict Standards: Declaration of MozillaPersonaPrivacyPolicy::Validate() should be compatible with MozillaPersonaOption::Validate($value, $options) in /var/www/clients/client2/web18/web/wp-content/plugins/browserid/lib/browserid-options.php on line 397

Strict Standards: Declaration of MozillaPersonaButtonColor::Validate() should be compatible with MozillaPersonaOption::Validate($value, $options) in /var/www/clients/client2/web18/web/wp-content/plugins/browserid/lib/browserid-options.php on line 500

Deprecated: Assigning the return value of new by reference is deprecated in /var/www/clients/client2/web18/web/wp-content/plugins/db-cache-reloaded-fix/db-cache-reloaded.php on line 91
krydos commented 11 years ago

As I can see this issue has been resolved with commit a154b4e

kitchin commented 10 years ago

Still getting this error with WP_DEBUG. The fix at https://github.com/shane-tomlinson/browserid-wordpress/pull/88 looks correct and works for me, but is not merged into master on git (0.47) or the latest version at http://wordpress.org/plugins/browserid/ (0.48 on trac).

WP_DEBUG is important for many devs, and the authorization code in WP is confusing, so it would be great to get that patch landed.

shane-tomlinson commented 10 years ago

Creating a new version of the browserid-wordpress plugin now. v0.49 imminent.

shane-tomlinson commented 10 years ago

PR #88 fixes this problem.