search

shaneMangudi / bcrypt-nodejs

Native implementation of bcrypt for NodeJS
Other
574 stars 69 forks source link

Bug with 31 rounds ? #17

Open fpirsch opened 11 years ago

fpirsch commented 11 years ago

I can barely compute a hash when the number of rounds approaches 20. With 30 rounds my desktop freezes. So far it's OK, bcrypt is supposed to be CPU-intensive. But surprisingly with 31 rounds I get a hash almost instantly.

johnnyleung commented 10 years ago

I'm guessing its an overflow issue. Looks like this is a pretty common issue in various bcrypt implementations. See this: http://stackoverflow.com/questions/2222383/why-does-bcrypt-net-generatesalt31-return-straight-away

fpirsch commented 10 years ago

Issue fixed, with various others, in this fork: https://github.com/fpirsch/twin-bcrypt