search

shaneMangudi / bcrypt-nodejs

Native implementation of bcrypt for NodeJS
Other
574 stars 69 forks source link

Resolution to issue #11 as raised and debugged by dcodeIO #21

Open markau opened 10 years ago

markau commented 10 years ago

This improves bcrypt-nodejs compatability with the bcrypt package.

i.e. when writing code against the bcrypt library, and changing libraries to use bcrypt-nodejs instead, node raises a runtime error which is resolved with this change.

julianlam commented 10 years ago

:+1: Looking forward to seeing this merged in.

TessMyers commented 9 years ago

It'd be sweet to see this merged in, or even just a mention in the docs that the progress argument in .hash() needs to be null if not provided.

joshball commented 9 years ago

@markau @julianlam @TessMyers This seems to have been partially fixed, but might not be as complete as this fix. Can one of you update the PR, and I will get it merged.