search

shaneMangudi / bcrypt-nodejs

Native implementation of bcrypt for NodeJS
Other
574 stars 69 forks source link

Error: global leak detected: lr #48

Open fb13 opened 9 years ago

fb13 commented 9 years ago

Hi,

At some place in your code you are missing the "var" statement and thereby declare a global variable. I get the following error in a mocha test case: Error: global leak detected: lr

Potentially in the function crypt_raw.

Cheers

eperedo commented 9 years ago

Seems like this was fixed in version 0.1.0, there's any chance you can publish this version to npm?

Thank you!

dtoubelis commented 8 years ago

+1. The version from npm, which is 0.0.3 has the global leak and it is not present in master. So, could you please push the latest master to npm?

nadav-dav commented 8 years ago

:+1:

manuel-di-iorio commented 8 years ago

:+1:

sandipwane commented 8 years ago

Guys has fixed version been pushed to npm. I ran into same issue can't seem to fix this

bcowgill commented 7 years ago

this is still broken. crypt_raw refers to lr without a var lr at the top of the function thus blatting global.lr bcrypt-nodejs@0.0.3

bcowgill commented 7 years ago

never mind, just saw the not maintained notice and reference to https://github.com/dcodeIO/bcrypt.js