search

shaneMangudi / bcrypt-nodejs

Native implementation of bcrypt for NodeJS
Other
574 stars 69 forks source link

Readme Badges #9

Closed nisaacson closed 11 years ago

nisaacson commented 11 years ago

I added Travis-CI and David badges to the readme. You will need to enable travis-ci for this repo on your account for the travis badge to activate

http://about.travis-ci.org/docs/user/getting-started/

nisaacson commented 11 years ago

@shaneGirish do you have an opinion on the 2 vs 4 spaces issue? Personally I think 2 spaces is easier to read so that's what I do in my own code. Are you okay with switching bcrypt-nodejs over to 2 spaces?

shaneMangudi commented 11 years ago

Not sure if I'm ok with that. I'm using 4 spaces on my current project. Maybe it's my font or something, but things look a bit off with 2 spaces. On Mar 21, 2013 12:05 AM, "Noah Isaacson" notifications@github.com wrote:

@shaneGirish https://github.com/shaneGirish do you have an opinion on the 2 vs 4 spaces issue? Personally I think 2 spaces is easier to read so that's what I do in my own code. Are you okay with switching bcrypt-nodejs over to 2 spaces?

— Reply to this email directly or view it on GitHubhttps://github.com/shaneGirish/bcrypt-nodejs/pull/9#issuecomment-15194828 .

nisaacson commented 11 years ago

what is your editing environment?

shaneMangudi commented 11 years ago

Yeah, we'll have to decide on a style guide if we're going to keep at this. And add a 'development' branch as well. And maybe stick only versions of the code that is going to be published to npm inside the 'master' branch.

Also, have you guys noticed that this module isn't really async. I mean, it uses process.nextTick(), which doesn't provide the benefits you would expect in a multi-core environment. Maybe we should add an example to the README.MD which uses real threads to do async and some tests for the same.

shaneMangudi commented 11 years ago

I use Sublime Text 2. Also, I got the JSLint plugin for it after you told me about it :) Apart from a tiny lag whenever I save the file, it really does help especially when I'm really really careless.

nisaacson commented 11 years ago

I can start working on some async stuff. Will you accept the pull request to add the dependency and build state badges?

shaneMangudi commented 11 years ago

Nah, leave the async to me. I already have the code spread out in 2 other projects of mine. I'll just put up the example some time today or tomorrow. I'll put it in a issue and give both of you guys a nudge. We''l decide what to do with it together.

nisaacson commented 11 years ago

cool