search

shanebarringer / webhook-concept

1 stars 0 forks source link

[WIP] - Refactor #47

Closed shanebarringer closed 6 years ago

shanebarringer commented 6 years ago

@antoniojgage @eamoses

in the attached commit, I've reduced things down to a single issues endpoint. This is strictly a proposal atm.

The GH webhook issues event listener support the following events:

opened, edited, closed, reopened, assigned, unassigned, labeled, unlabeled, milestoned, or demilestoned.

Not saying we'll perform an action on all of these events, but i'm thinking that we can use a switch statement to handle incoming events.

Curious to hear your thoughts.

shanebarringer commented 6 years ago

@brandonkearns also want to hear your thoughts

shanebarringer commented 6 years ago

@antoniojgage @eamoses when you get a minute can you take a look at this?

antoniojgage commented 6 years ago

The code looks good for me but I'm curious why the code owners script didn't work.

shanebarringer commented 6 years ago

@antoniojgage Thanks for the review! I think the codeowners did work. however, it may have not made it to your notifications. Will plan on keeping an eye on it.