search

shanebo / icalevent

a node module for creating ical events
MIT License
35 stars 15 forks source link

can we make 'method' a VCALENDAR property #9

Open maxwellutd opened 9 years ago

maxwellutd commented 9 years ago

Had issues with getting the calendar invites to appear in the email with RSVP actions. It turned out that "method: REQUEST" part shouldn't be under VEVENT but VCALENDAR.

shanebo commented 9 years ago

Did you test this on multiple platforms and email clients?

On Jun 4, 2015, at 9:29 PM, maxwellutd notifications@github.com wrote:

Had issues with getting the calendar invites to appear in the email with RSVP actions. It turned out that "method: REQUEST" part shouldn't be under VEVENT but VCALENDAR.

— Reply to this email directly or view it on GitHub https://github.com/shanebo/icalevent/issues/9.

maxwellutd commented 9 years ago

Yeah i did. Every example that i went through said it needed to be under the VCALENDAR. That one change made it work on multiple platforms for me.

On Tue, Jun 9, 2015 at 3:32 AM, shanebo notifications@github.com wrote:

Did you test this on multiple platforms and email clients?

On Jun 4, 2015, at 9:29 PM, maxwellutd notifications@github.com wrote:

Had issues with getting the calendar invites to appear in the email with RSVP actions. It turned out that "method: REQUEST" part shouldn't be under VEVENT but VCALENDAR.

— Reply to this email directly or view it on GitHub < https://github.com/shanebo/icalevent/issues/9>.

— Reply to this email directly or view it on GitHub https://github.com/shanebo/icalevent/issues/9#issuecomment-110084774.

shanebo commented 9 years ago

@maxwellutd great. Please submit a pull request with the change and I'll review it. Thanks.

wearhere commented 8 years ago

This is fixed by @sourcehunter in https://github.com/shanebo/icalevent/pull/7.