search

shanehofstetter / youtrack-rest-client

youtrack REST API client written in typescript
https://www.npmjs.com/package/youtrack-rest-client
MIT License
38 stars 21 forks source link

@types/request-promise dependency #1

Closed kpala closed 5 years ago

kpala commented 5 years ago

Hello there! Using this package in a TypeScript project gives the following compilation error:

node_modules/youtrack-rest-client/dist/entities/base.d.ts:2:32 - error TS7016: Could not find a declaration file for module 'request-promise'. '<...>/node_modules/request-promise/lib/rp.js' implicitly has an 'any' type.
  Try `npm install @types/request-promise` if it exists or add a new declaration (.d.ts) file containing `declare module 'request-promise';`

2 import { RequestPromise } from "request-promise";

@types/request-promise should be probably included in the dependencies instead of devDependencies. https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

shanehofstetter commented 5 years ago

Hi, thanks for report, I moved the dependencies now and published it with v0.3.2.