Closed ScottFreeCode closed 3 years ago
In https://github.com/shanejansen/touchstone/commit/4fe636c2b0fe414902ff18d94a00b84035ebc805#diff-f00ff2c353e1ab98d15ad58bb6a842e49495c52107bc800ddce3783d412b1dcbL49-R59 a bug was corrected around expecting 0 calls to a REST API. The fix was to change not n, which is also True for 0 rather than only None, to n is None, which is False for 0.
not n
True
0
None
n is None
False
(The MySQL mock didn't seriously need this since it has row_does_not_exist; however, other mocks would be helpful to have a similar fix applied.)
row_does_not_exist
All the code I could find where the logic should be corrected are:
In https://github.com/shanejansen/touchstone/commit/4fe636c2b0fe414902ff18d94a00b84035ebc805#diff-f00ff2c353e1ab98d15ad58bb6a842e49495c52107bc800ddce3783d412b1dcbL49-R59 a bug was corrected around expecting 0 calls to a REST API. The fix was to change
not n, which is alsoTruefor0rather than onlyNone, ton is None, which isFalsefor0.(The MySQL mock didn't seriously need this since it has
row_does_not_exist; however, other mocks would be helpful to have a similar fix applied.)All the code I could find where the logic should be corrected are: