shanemadden / factorio-deadlock-beltboxes-loaders

Other
8 stars 17 forks source link

Updated for Factorio 2.0. #38

Closed Synthlight closed 2 weeks ago

Synthlight commented 1 month ago

PS: If you aren't interested in maintaining it anymore, let me know. I'd be happy to take over the mod. (Not sure if mod portal transfers are a thing or not.) Either way, I'm not gonna upload it as a mod there till I hear back or there's silence for a week or something.

shanemadden commented 1 month ago

Thanks for the PR! I should have some time to get it tested out and released this weekend.

daz96050 commented 1 month ago

Error while applying migration: Deadlock's Stacking Beltboxes & Compact Loaders: deadlock-beltboxes-loaders_2.0.2.lua

LuaTechnology doesn't contain key effects. stack traceback: [C]: in function 'index' ...oaders/migrations/deadlock-beltboxes-loaders_2.0.2.lua:5: in main chunk

daz96050 commented 1 month ago

Removing the migration files entirely seems to fix the issue, if it's a 2.0 save.

Synthlight commented 1 month ago

lol. That's what I mean by "migrations untested". It at least worked for saves made in 2.0 when increasing the version number. (Though the version was already way past the migration version so...) Some of the tech names changed. You can check the changelog for 2.0.7 and ctrl+f the tech.

For effects here you'd: for _, effect in pairs(technology.effects) do -> for _, effect in pairs(technology.prototype.effects) do

I hesitate to commit anything affecting migrations though since I've never looked into how they work.

Synthlight commented 3 weeks ago

Thanks for the PR! I should have some time to get it tested out and released this weekend.

Poke. It's been two weeks. Not sure what's up on your end, but I'd like to get an updated version on the mod portal.

shanemadden commented 3 weeks ago

Sorry for the delay, aiming to try to get this done later today.

shanemadden commented 2 weeks ago

Thanks again! Should have this released shortly.