search

shaneriley / modal

A basic jQuery modal plugin built around Hashrocket's usual modal needs.
23 stars 3 forks source link

Dynamic jQuery extension is insane #2

Closed daytonn closed 10 years ago

daytonn commented 10 years ago

Extending jQuery fn with the modal name, isnot a good idea. What if I name my modal "find". At the very least, you should make people very aware that you've supplied them with a nuclear weapon.

shaneriley commented 10 years ago

If you call it "find", then you're modifying the plugin. If you're modifying the plugin, you'd better know what you're doing. I don't see the issue here.