shanesmith / gerrit-cli

Gerrit in your command lines.
MIT License
46 stars 19 forks source link

gerrit up --assign doesn't work with multiple commits in topic #15

Closed jpl-mac closed 8 years ago

jpl-mac commented 8 years ago

Expected: all commits are pushes and assigned to the reviewer

Observed: Command fails with the following error stack. No commits are pushed to gerrit

$ ger up --assign reviewer More than one patch detected. ? Assign reviewers to all patches being pushed? (Y/n) gerrit WARN Aborting. gerrit ERROR UNKNOWN Error: undefined gerrit ERROR domain: {"domain":null,"_events":{},"members":[]} gerrit ERROR domainThrown: true gerrit ERROR at Object.ensureErrorObject (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/util.js:261:20) gerrit ERROR at Promise._rejectCallback (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:465:22) gerrit ERROR at Function.Promise.reject.Promise.rejected (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:195:9) gerrit ERROR at /usr/local/lib/node_modules/gerrit-cli/lib/cli.js:724:18 gerrit ERROR at bound (domain.js:254:14) gerrit ERROR at runBound (domain.js:267:12) gerrit ERROR at tryCatcher (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/util.js:26:23) gerrit ERROR at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:503:31) gerrit ERROR at Promise._settlePromiseAt (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:577:18) gerrit ERROR at Promise._settlePromises (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:693:14) gerrit ERROR at Async._drainQueue (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:123:16) gerrit ERROR at Async._drainQueues (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:133:10) gerrit ERROR at Immediate.Async.drainQueues as _onImmediate gerrit ERROR at processImmediate as _immediateCallback ? Assign reviewers to all patches being pushed? Yes