shanewfx / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

google-glog test suite does not run on armel / armhf #140

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
google-glog test suite currently fails with:

./src/logging_striplog_test.sh
In DBG mode; not checking strings
PASS
./demangle_unittest  # force to create lt-demangle_unittest
Passed 3 tests

PASS
./src/demangle_unittest.sh
PASS
./signalhandler_unittest  # force to create lt-signalhandler_unittest
OK
./src/signalhandler_unittest.sh
'DieInThread' should appear in the output
make[3]: *** [signalhandler_unittest_sh] Error 1
make[2]: *** [check-am] Error 2

See:
https://buildd.debian.org/status/fetch.php?pkg=google-glog&arch=armhf&ver=0.3.2-
4&stamp=1353840646
and
https://buildd.debian.org/status/fetch.php?pkg=google-glog&arch=armel&ver=0.3.2-
4&stamp=1353840699

Please add support for arm* platform. Thanks

Original issue reported on code.google.com by mathieu.malaterre on 17 Dec 2012 at 11:46

GoogleCodeExporter commented 9 years ago
I'm not sure from the project page how to submit a patch, but this avoids the 
build failure:

=== modified file 'src/signalhandler_unittest.sh'
--- src/signalhandler_unittest.sh   2012-06-21 21:07:21 +0000
+++ src/signalhandler_unittest.sh   2013-03-13 14:15:15 +0000
@@ -72,6 +72,13 @@
   exit 0
 fi

+# The symbols don't match on ARM.
+# We just skip the test for ARM.
+if [ `expr match \`uname -p\` "arm*"` ]; then
+  echo "PASS (We don't test the signal handler on ARM.)"
+  exit 0
+fi
+
 # Test for a case the program kills itself by SIGSEGV.
 GOOGLE_LOG_DIR=. $BINARY segv 2> signalhandler.out1
 for pattern in SIGSEGV 0xdead main "Aborted at [0-9]"; do

Original comment by a...@octopull.co.uk on 13 Mar 2013 at 2:36

GoogleCodeExporter commented 9 years ago
Actually the test only passes for x86 and x86_64 (as per documentation), so 
instead of doing :

if [ `expr match \`uname -p\` "ppc*"` ]; then
if [ `expr match \`uname -p\` "mips*"` ]; then
if [ `expr match \`uname -p\` "arm*"` ]; then
...

I think upstream should really state there intention in the test.

Original comment by mathieu.malaterre on 13 Mar 2013 at 2:52