shangar21 / anime_upscaler

My usage of Real-ESRGAN to upscale anime, some test and results in the test_img folder
80 stars 7 forks source link

Runtime Exception: NPArray does not have method save #5

Closed jdmg94 closed 8 months ago

jdmg94 commented 8 months ago

Thanks for this project it seems very promising and I am very excited to restore some of my childhood animes. However I've stumbled on an issue after cloning the repo and installing its requirements.txt (which has a conflict on Pillow versions btw)

Now when I run the script it succesfully extract the frames but once it gets to upscaling it fails on this line:

https://github.com/shangar21/anime_upscaler/blob/main/anime_upscaler.py#L77

I digged a bit through the code and it seems like the issues is that on upscale_slice it returns a nparray instead of an Image

shangar21 commented 8 months ago

Thnks for letting me know, in fact it helped me find another issue with the audio kind of screwing up the video output as well somehow when using moviepy and thus I changed to an ffmpeg subprocess call instead. Will merge the fix soon

shangar21 commented 8 months ago

Closing issue as PR with ffmpeg is merged