search

shangar21 / anime_upscaler

My usage of Real-ESRGAN to upscale anime, some test and results in the test_img folder
79 stars 7 forks source link

Current requirements.txt leads to pip conflict #7

Closed mo-st closed 3 months ago

mo-st commented 5 months ago

Install with pip install -r requirements.txt leads to the following dependency conflict:

The conflict is caused by:
    The user requested Pillow==10.1.0
    basicsr 1.4.2 depends on Pillow
    image-slicer 2.1.1 depends on Pillow==7.2.0

I will try to run with removing the version specification for pillow entirely and update this issue after testing it. Cheers and thanks for your scripts!

mo-st commented 5 months ago

Update: doesn't seem to work, neither does setting version ==7.2.0. Don't have time to look into the specifics atm, building wheel fails though. Will update if I find the time.

shangar21 commented 5 months ago

Yeah I think the problem is with image_slicer, I will eventually write the slicer myself but if you want to install it, try to git clone the source repo and build with pip install -e . instead: https://github.com/samdobson/image_slicer (assuming you have the rest of the dependencies installed).

sampanes commented 3 months ago

I have a venv and I have several repos in it, the third of which is now image_slicer, I went into that directory and did pip install -e . and got image-slicer, then pillow wasn't working so I went back and did pip install Pillow==10.1.0, then ran the frame_esrgan.py on an image and got decent output (disney movie frame, not anime) so I think this is the right answer

shangar21 commented 3 months ago

Awesome. closing the issue now then