shangdawei / btstack

Automatically exported from code.google.com/p/btstack
0 stars 1 forks source link

Wrong definitions in hci_cmds.h #414

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I was confused because of some result code after the L2CAP Connection Response 
signalling command. I received 0x67 which is 0x63+4=0x67.
The correct error code would be 
L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_RESOURCES.

But please see the current definitions in hci_cmds.h:

#define L2CAP_CONNECTION_RESPONSE_RESULT_SUCCESSFUL        0x63
#define L2CAP_CONNECTION_RESPONSE_RESULT_PENDING           0x64
#define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_PSM       0x65
#define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_SECURITY  0x66
#define L2CAP_CONNECTION_RESPONSE_RESULT_REFUSED_RESOURCES 0x65
#define L2CAP_CONNECTION_RESPONSE_RESULT_RTX_TIMEOUT       0x66

I assume a copy&paste bug.

Original issue reported on code.google.com by c.w...@mail.de on 23 Aug 2014 at 9:57

GoogleCodeExporter commented 9 years ago
I guess that this issue can be closed. 
It was fixed in the SVN.

Original comment by c.w...@mail.de on 25 Aug 2014 at 2:21

GoogleCodeExporter commented 9 years ago
thanks (still trying how the auto-close feature works)

Original comment by matthias.ringwald@gmail.com on 25 Aug 2014 at 2:22