search

shaniceng / pe

0 stars 0 forks source link

Long exercise names #2

Open shaniceng opened 1 year ago

shaniceng commented 1 year ago

when used long exercise names:

image.png

nus-se-script commented 1 year ago

Team's Response

Hi there! Thank you for your report.

We will be rejecting this bug because of the following reasons:

  1. The ellipsis was shown was due to the screen being compressed to a very small size. This was intended as we believe the alternative implementation we had in mind of having the entire name wrapped in the Exercise List card can make it a lot messier. Moreover, even with the screen compressed to such a small size, it can still accept up to 16 characters which is rather generous for an exercise name. If the user wants to view the full exercise name, he/she can simply enlarge the screen slightly or open the screen in full.
  2. The expected response stated was to show the names truncated which in our opinion, is less optimal as the user might not even know that the exercise name shown was not complete. eg. Barbell Bench press being viewed as Barbel... (with ellipsis) is a lot clearer than simply Barbel (truncated)

Thank you once again for your report!

GIM

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since the application is allowed to be compressed to a very small size, there will be users who will use the application in a very small size in the case where they would like to multitask. I understand that this situation is unlikely to affect normal operations of the product, hence I have decided to give a low severity as it does cause minor inconvenience to some users in this situation.

Allow me to give you few examples that will hinder the use of this application in a compressed size:

  1. Abdominal Double Crunch : has 23 characters which will not allow the user to see 'Crunch' at all.
  2. Ankle Plantar Flexion - Knee Bent : has 33 characters which will not allow the user to see anything after 'Ankle Plantar Fl...'
  3. Ankle Plantar Flexion - Knee Straight : has 36 characters which will not allow the user to see anything after 'Ankle Plantar Fl...'

By comparing examples 2 and 3, we can see that the user will not be able to differentiate between these 2 exercise and cause minor inconvenient to some users who wants to input these exercises in this application.

Just to clarify, what I meant by the expected output is that it should be able to display all of the characters and be truncated to the next line instead of adding ellipsis, it is a form of word choice error and it was my mistake for not being clear in my issue description.

Examples for the expected output:

  1. Abdominal Double
    Crunch
  2. Ankle Plantar
    Flexion - Knee
    Bent
  3. Ankle Plantar
    Flexion - Knee
    Straight

Given these examples, I believe that this should be considered a low.severity issue under FeatureFlaw bug type as this could have been solved in v1.4.

These exercises names were taken from google, where there are many other examples with exercise names that has more than 16 characters.

image.png