Closed shanilpanara closed 4 years ago
I like it - some points::
Edge
should have a function (not property since there are many parameters that we can change e.g. sequence) called strand()
- which means the following:
Edge
shouldn't create a System
nucleotides
property of Edge
should be removed - an Edge
should be purely geometrical (not related to DNA) but with a sole 'gateway' to a DNA system by using the strand()
function - this is a more broad point that is subjective and up for discussionThe generate_helix
function should be in the strand.py
file (to help tidy things up)
sorted out passing a sequence when calling generateHelix
, this took a lot longer than it needed to!
added testing alongside this for both the generateHelix()
function and Edge.strand()
method
Each Edge should have a function (not property since...
Also worked on this, now we can pass any other parameters (which are passed into the generateHelix function) to the method in the Edge
class called strand()
We can then access this Strand
object stored within the Edge
object as EdgeObject.helix
@debeshmandal
@shanilpanara sounds good - have you pushed through everything yet? when you have, feel free to merge and then I will make some edits if necessary. After a quick glance, it looks great and any edits I make will be mostly cosmetic 👍
Everything is pushed that I have, will merge now @debeshmandal
Still need to clean up generate_helix code and add docstrings.
But now an edge creates its own
system
when initialised.Can now close #5
@debeshmandal I'm sure there will be clashes with your updates to the code, if its ok with you, I want to work through these tomorrow so I get some experience resolving conflicts.