shanilpanara / origamiUROP

Autonomous Generation of DNA Origami Nanostructures - Summer Project
GNU General Public License v3.0
1 stars 3 forks source link

Added generate_helix and integrated into Edge Class #22

Closed shanilpanara closed 4 years ago

shanilpanara commented 4 years ago

Still need to clean up generate_helix code and add docstrings.

But now an edge creates its own system when initialised.

Can now close #5

@debeshmandal I'm sure there will be clashes with your updates to the code, if its ok with you, I want to work through these tomorrow so I get some experience resolving conflicts.

debeshmandal commented 4 years ago

I like it - some points::

debeshmandal commented 4 years ago

The generate_helix function should be in the strand.py file (to help tidy things up)

shanilpanara commented 4 years ago

Main things from today:

@debeshmandal

debeshmandal commented 4 years ago

@shanilpanara sounds good - have you pushed through everything yet? when you have, feel free to merge and then I will make some edits if necessary. After a quick glance, it looks great and any edits I make will be mostly cosmetic 👍

shanilpanara commented 4 years ago

Everything is pushed that I have, will merge now @debeshmandal