search

shankar90 / sipdroid

Automatically exported from code.google.com/p/sipdroid
GNU General Public License v3.0
0 stars 0 forks source link

Caller ID option is not working for REGISTER #256

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Configured value of Caller ID is not used for REGISTER request.

I think it should be handled in the same way to INVITE for most SIP
providers. Attached patch resolves this issue and do not modify current
behavior when Caller ID option is null.

I also suggest to move the Caller ID option to "Account settings" instead
of "Advanced options" (although not included in this patch).

Original issue reported on code.google.com by tm.in...@gmail.com on 29 Dec 2009 at 3:42

Attachments:

GoogleCodeExporter commented 9 years ago 
Looks good to me. Check it in!

Does this resolve issue 138 / issue 207?

Original comment by pmerl...@googlemail.com on 29 Dec 2009 at 9:19

GoogleCodeExporter commented 9 years ago 
I have checked in (r401).

Issue 207 can be resolved, but I'm not sure for issue 138.
Issue 138 requires different set of callerid/username/password for REGISTER and
INVITE respectively.

Original comment by tm.in...@gmail.com on 30 Dec 2009 at 1:12

GoogleCodeExporter commented 9 years ago

Original comment by pmerl...@googlemail.com on 18 Jan 2010 at 3:24