search

shankarpandala / lazypredict

Lazy Predict help build a lot of basic models without much code and helps understand which models works better without any parameter tuning
MIT License
2.86k stars 329 forks source link

Solve#114 #319

Closed toprakmurat closed 3 years ago

toprakmurat commented 3 years ago

I thought this can be a solution. Can you review it?

toprakmurat commented 3 years ago

I could not understand why codefactor found and error just in 531 - 669. It is the same thing with the lines 230 - 395.

toprakmurat commented 3 years ago

I made the changes @brendalf

brendalf commented 3 years ago

Fantastic, @toprakmurat .

I'm closing the requested changes, but opening a new one. There is two blocks of code with a wrong indentation in your last commit. The first on line 291 and the second on line 592.

toprakmurat commented 3 years ago

Thank you for all of your reviews @brendalf. They are priceless for me as an amateur. I hope there is no more errors :)

brendalf commented 3 years ago

Thank you @toprakmurat :)