Fix for boolean return values encoded as `c`

shannah / Java-Objective-C-Bridge

A thin bridge that allows for two-way communication from Java to Objective-C.

123 stars 25 forks source link

Fix for boolean return values encoded as `c` #12

Closed mojo2012 closed 5 years ago

mojo2012 commented 5 years ago

boolean return values are now correctly handled when using a signature like c@: Also some more KVO selectors are implemented and redirected to the java peer

mojo2012 commented 5 years ago

Basically this PR contain:

proper handling of nsstring subclasses
some (probably not all) KVO related selectors forwarded to java (KV from java objects to java objects works too)
java11 automatic module config
switched to maven build system (netbeans/ant build didn't work for me at all)
boolean values ('c' symbol definition) didn't work correctly
redirect all unimplemented proxy methods to java
restructured code base to match maven style

If you have time you can look at the changes an manually copy what you need. I will probably merge the project (including my changes) into https://github.com/mojo2012/kakao. As kakao is a maven project I need j-o-c-bridge to be a maven artifact too (hence the change)

shannah commented 5 years ago

Kakao looks interesting. I like the direction of this pull request but there are some details that need to be finished. E.g.

The README file needs to be updated with new build and usage instructions.
When building with mvn package, the tests fail. This is likely because the dylib isn't built directly.
The repo no longer includes the prebuilt dylib. It would be really nice if we could have the maven build run xcodebuild on the dylib project to automatically build and include the dylib.

mojo2012 commented 5 years ago

Yes you are absolutely right. I was planning to do this but kinda forgot about it. I will update the readme and use maven to build the dylib. Fyi, what you can do with kakao with only a few lines of code: Screenshot 2019-07-28 at 15 06 36

EDIT: i updated my master branch, but github doesn't seem to see the changes ...

shannah commented 5 years ago

I just checked out your latest. It seems that mvn clean install will build the library with Xcode build. But tests still fail. It doesn't seem to copy the dylib anywhere. Am I missing something in the build process?

mojo2012 commented 5 years ago

Sorry for that (it worked on my machine ...). I fixed the build and now the tests should work for you too.

shannah commented 5 years ago

Great! Thanks!