search

shannah / Java-Objective-C-Bridge

A thin bridge that allows for two-way communication from Java to Objective-C.
123 stars 25 forks source link

Add GitHub Maven workflow #37

Closed Marcono1234 closed 3 years ago

Marcono1234 commented 3 years ago

Closes #16

This will run a Maven build for every push and every pull request. In case this becomes annoying for separate development branches or draft pull request, it can be restricted to certain branches.

You could also add a separate workflow for deploying to Maven Central, see GitHub Docs article, though for signing artifacts additional modifications will be needed (but I am not familiar with this).

⚠️ Currently the builds are failing (see this run):

/Users/runner/work/Java-Objective-C-Bridge/Java-Objective-C-Bridge/src/main/objectivec/implementation/WLJavaProxy.m:10:10: fatal error: 'JavaNativeFoundation/JavaNativeFoundation.h' file not found
#include <JavaNativeFoundation/JavaNativeFoundation.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/Java-Objective-C-Bridge/Java-Objective-C-Bridge/src/main/objectivec/implementation/WLJavaProxy.m:10:10: note: did not find header 'JavaNativeFoundation.h' in framework 'JavaNativeFoundation' (loaded from '/System/Library/Frameworks/JavaVM.framework/Versions/A/Frameworks')
1 error generated.

Do you think the workflow is missing something? I sadly don't think that I am able to solve this.

shannah commented 3 years ago

Thanks. used your workflow, but just added the DEVELOPER_DIR environment variable and it seems to work fine now.

Marcono1234 commented 3 years ago

No problem and thanks for fixing the workflow file. I will close this pull request then.

Maybe it would be good to remove the Travis CI files then as well, since they are not needed anymore?