search

shannah / xataface

Framework for building data-driven web applications in PHP and MySQL
http://xataface.com
GNU General Public License v2.0
134 stars 57 forks source link

PHP7 Edits #86

Closed lemondexter closed 7 years ago

lemondexter commented 7 years ago

Changes to avoid PHP warnings "Methods with the same name as their class will not be constructors in a future version of PHP" when running PHP 7.x on server.

dgleba commented 7 years ago

If this was merged in, would it still work with php5? I am still using php5. Also, in some apps where I use viharm's LDAP auth module, click here, I don't use mysqli because it throws an error.

shannah commented 7 years ago

I noticed that this fork must have been from a few revisions back as it reverted some things other than the constructors. I just wrote an automated tool to find and update all of the PHP files in xataface (https://github.com/shannah/xataface/commit/0187f3836639a641f3f22eca71ee011b66eb42d9). This should resolve the issues for you. Let me know if you spot any other issues.

shannah commented 7 years ago

@dgleba These changes are fully compatible with PHP 5.