BCs input parameters have been updated and deprecated for all AD BCs

shannon-lab / zapdos

Open source MOOSE framework application for simulating plasmas

https://shannon-lab.github.io/zapdos/

GNU Lesser General Public License v2.1

39 stars 38 forks source link

BCs input parameters have been updated and deprecated for all AD BCs #226

Closed gsgall closed 9 months ago

gsgall commented 11 months ago

input parameters were made consistent with issue #223
secondary electron emmision coefficients were made material and species dependent
secondary electron energy was moved to a BC input parameters
several test inputs were updated in order to facilitate this as well

moosebuild commented 11 months ago

Job Documentation on 6f1c46d wanted to post the following:

View the site here

This comment will be updated on new commits.

cticenhour commented 11 months ago

@gsgall I will review this one, since Corey is working on your other one. Not sure if I'll get to it today or tomorrow, but just acknowledging it. Thanks!

moosebuild commented 10 months ago

Job Precheck on 590257e wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/zapdos/docs/PRs/226/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 8d2303cac564b917340c82d49d9670f1b84cbe8f

gsgall commented 9 months ago

@cticenhour I updated all of the secondary electron emission coefficients to be material properties so I think everything else should be good to go. If this passes approval I can go ahead and squash all of the commits before merging.