shannonfromomaha / 02-29-pair-project

0 stars 0 forks source link

tests/unit/pledge_test Issue Duplicate Method Call #45

Closed shannonfromomaha closed 8 years ago

shannonfromomaha commented 8 years ago

[23, 29]:DuplicateMethodCall: PledgeTest#setup calls @g.id 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [36, 38]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls @g.id 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [39, 41]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls @p2.amount 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [39, 41]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls @u2.email 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [39, 41]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls @u2.name 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [36, 38]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls Pledge.collect_pledges(@g.id) 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]

shannonfromomaha commented 8 years ago

after previous issues fixed, the remaining lines of this error are:

[26, 32]:DuplicateMethodCall: PledgeTest#setup calls @gift_banana.id 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [39, 41]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls @gift_banana.id 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md] [39, 41]:DuplicateMethodCall: PledgeTest#test_collect_pledges calls Pledge.collect_pledges(@gift_banana.id) 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]

shannonfromomaha commented 8 years ago

the redundancy in those lines is acceptable to the team.