shannonj498
commented
7 years ago Thank you so much for the feedback! I will implement everything you suggested right away and work on more responsive designs. Thank you!
Open josephtkim opened 7 years ago
shannonj498
commented
7 years ago Thank you so much for the feedback! I will implement everything you suggested right away and work on more responsive designs. Thank you!
Grade: Meets Expectations
Summary: Great job with your first official project in the program! It is no small feat to take a specification image and to build a working webpage from it, so you should be proud! The page design looked great, and seems to follow the provided specification for most of the design and layout. In addition, the code was well formatted and structured, making it easily readable.
There were several areas for improvement here. First, make sure to apply the font-size to the heading element directly, because applying it to the parent will make the text size relative to that, instead of the size you want. Next, for best code formatting practice, use 2 spaces per indent. In addition, give a description for each section of code, and an alt attribute to each img element to provide descriptions. Finally, it is best to simplify your CSS code for shared properties to make it more concise.
As a further challenge, consider adding responsive design to your page. This might take some extra research, but can be a great way to learn and apply important web design concepts. You can take a look at these resources to get started - http://getbootstrap.com/ and https://css-tricks.com/snippets/css/a-guide-to-flexbox/. Based on your work so far, I think you are up for the challenge. Keep up the great work!