search

shannonmj / codepath-twitter

MIT License
0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 5 years ago

codepathreview commented 5 years ago

👍 Nice work Shannon. It's great to see how far you've come after the first two weeks of the course! This past week we focused a lot on navigation with intents, customizing the App Bar / ToolBar, debugging, and using device SDK's (like camera and maps). We also got more practice sending network requests and passing parameters to the Twitter API. We hope you found this assignment useful and learned a lot while building your own Twitter app!

We put together a detailed Project 3 Feedback Guide here which covers the most common issues with this project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Next week we'll be extending our Twitter Client to learn how to use tabbed navigation and add extra functionality.

dafeilei commented 5 years ago

Feedback to improve the code quality:

  1. make member field private as default.
  2. properly group the files into different folders, so that in the future expansion of the project, the architecture will be more clear.
  3. Clean up/format the code before submission.
  4. Break down big functions into smaller functions will make the code more readable.