shannonmoeller / gulp-hb

A sane Gulp plugin to compile Handlebars templates. Useful as a static site generator.
http://npm.im/gulp-hb
MIT License
147 stars 14 forks source link

Adds support for nested partial names #4

Closed kflorence closed 9 years ago

kflorence commented 9 years ago
kflorence commented 9 years ago

@shannonmoeller Another thing to consider would be using gulp.src (or vinyl-fs.src which is what gulp uses) instead of the current method of getting files since there is a bit of duplicated logic around paths in here otherwise and it seems cleaner to just use them instead.

kflorence commented 9 years ago

@shannonmoeller Is there something I can do to get this merged faster? Right now I have a local copy of this that I'm using, but it would be cleaner if I could pull it down instead.

shannonmoeller commented 9 years ago

This is a good change, but it doesn't entirely follow the code standards. Please join your multiple var statements into a single var block, separated by commas. It's a Crockford thing I haven't given up yet. :)

kflorence commented 9 years ago

@shannonmoeller cool, I will do that in a bit.

shannonmoeller commented 9 years ago

Published as v0.2.0!

kflorence commented 9 years ago

@shannonmoeller thanks :)