search

shannonmoeller / gulp-hb

A sane Gulp plugin to compile Handlebars templates. Useful as a static site generator.
http://npm.im/gulp-hb
MIT License
148 stars 14 forks source link

Allow file-specific data in options.data #48

Closed backflip closed 7 years ago

backflip commented 7 years ago

Previously, dataEach allowed us to define file-specific @root data. Allowing a function for options.data would restore this functionality.

See https://github.com/shannonmoeller/gulp-hb/issues/10#issuecomment-275220220

/cc @swey

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 84d4cf5fc0b890558a38846518abaa994034b778 on unic:feature/file-specific-data into 3270f2735610107f7872df8bc8d2c3503c424d7b on shannonmoeller:master.

shannonmoeller commented 7 years ago

Thank you for the PR, but I'm closing this in favor of updaing handlebars-wax to the latest version which should address @sway's issue.

shannonmoeller/gulp-hb#49 shannonmoeller/handlebars-wax#12 unic/estatico#36

swey commented 7 years ago

Great work @shannonmoeller! Seems to fix the problem, thank you! 👍

PS: The latest version is not listed on npm yet

shannonmoeller commented 7 years ago

I suppose running npm publish is a good idea. :)

swey commented 7 years ago

Awesome speed, thanks!

backflip commented 7 years ago

Thanks a lot!