Change of behaviour of for inheritance with 2.0

shannonmoeller / handlebars-layouts

Handlebars helpers which implement layout blocks similar to Jinja, Nunjucks (Swig), Pug (Jade), and Twig.

http://npm.im/handlebars-layouts

MIT License

361 stars 29 forks source link

Change of behaviour of for inheritance with 2.0 #18

Closed Florian-R closed 9 years ago

Florian-R commented 9 years ago

Since the new release, templates inheriting template inheriting a top level template doesn't seem to be aware of the top level blocks. (sorry, i can't figure a way to articulate this cleany).

To better illustrate this, see this bin for v1.1.0 and this one with current master

A quick glance at the history let me think this change was introduced by 04ade656ffd699e7daa60ec96c549d750c8a40c9. I'm not sure this behavior is intended or not. Let me know, and i'll try to dig further in the code.

shannonmoeller commented 9 years ago

Good catch! Certainly not intended. I'll take a look tonight.

shannonmoeller commented 9 years ago

Found the problem. Released fix as v2.0.2.

Florian-R commented 9 years ago

Wow that was quick! Many thanks.