search

shannonmoeller / handlebars-wax

The missing Handlebars API for data, partials, helpers, and decorators.
http://npm.im/handlebars-wax
MIT License
40 stars 9 forks source link

Templating errors #7

Closed pmendelski closed 8 years ago

pmendelski commented 8 years ago

Hi, it's me again (https://github.com/shannonmoeller/handlebars-wax/issues/6).

Just one more question. Is it possible to produce an error when partial used in template was not found? I caught myself checking resulting html file multiple times.

Regards

shannonmoeller commented 8 years ago

Hmm. Could have sworn I had a test case for that. I'll whip one up. In the meantime, is it possible the error is getting swallowed somehow? Perhaps by a Promise?

pmendelski commented 8 years ago

Yes, it is possible. I'm using https://github.com/shannonmoeller/gulp-hb that wraps https://github.com/shannonmoeller/handlebars-wax. Maybe it's a problem in gulp-hb?

shannonmoeller commented 8 years ago

Oh, cool. Also possible. I'll make sure to get a test in there too.

pmendelski commented 8 years ago

Again, thank you very much.

shannonmoeller commented 8 years ago

I've added some tests and confirmed that errors throw by handlebars are not being swallowed by this lib. They raise like they should and can be handled with try/catch, etc. Closing this. Will continue looking into gulp-hb.