Add candy buttons (with sparkle)

bunnymatic commented 7 years ago

Here's the Candy Button treatment (without losing the sparkle).

The css and 1 image file are added under vendor/assets/{stylesheets,images} respectively.

In the index page, we choose randomly a shape class and color class and icon to render the buttons.

For more class options, check out the examples on http://simurai.com/archive/buttons/ (the page from which this was stolen)

screen shot 2017-02-04 at 4 11 59 pm

I don't really expect this to get merged, but it's a starting point for candy buttons if you wanted them.

shannonwells commented 7 years ago

Current plan is to merge this (with any desired tweaks) after permalinks.

bunnymatic commented 7 years ago

Sadly i'm having issues running tests with the new feature spec stuff...

screen shot 2017-02-14 at 12 24 58 am

  14) Clickbait Generator when I visit the home page when I click on a button behaves like a Clickbait Generator page lets me share the headline to Twitter
      Failure/Error: visit '/'

      Selenium::WebDriver::Error::UnknownError:
        Missing 'marionetteProtocol' field in handshake
      Shared Example Group: "a Clickbait Generator page" called from ./spec/features/clickbaits_spec.rb:61
      # ./spec/features/clickbaits_spec.rb:34:in `block (3 levels) in <top (required)>'

Running geckodriver 0.14.0

i'll look into it.

bunnymatic commented 7 years ago

Got it - old version of firefox (42.0). upgrade to 51 got the tests rolling

bunnymatic commented 7 years ago

Just rebased on the latest master. should be ready to roll once you take a look see

shannonwells commented 7 years ago

D'oh!

bunnymatic commented 7 years ago

here are current screenshots from that branch (on my dev box) - so responsive!

screen shot 2017-02-16 at 9 07 52 pm

bunnymatic commented 7 years ago

my bad on the force push.

This last commit is on top of your font and shape mods. Added new icons that are tied to the different list icon types. and added sparkles to the permalink share button

bunnymatic commented 7 years ago

Just doing a little research - on my machine, changing the icon font to sans-serif makes the smiley face crappy and doesn't change the colored icons at all (the sand timer and the skull). i wonder if we need a proper icon font to be available to the app. or we make custom fonts with icomoon...

bunnymatic commented 7 years ago

also - i don't (think I) see the offset sparkley issue on this branch. unless i'm missing something

shannonwells commented 7 years ago

ok, if you can please double check that the sparkley offset isn't happening, and merge if it's not, and fix & merge if it is, then let's not make any further changes. We (or I) can figure out the font to use in another branch/PR.

bitmoji

bunnymatic commented 7 years ago

fair 'nuf.

i'll double triple check

On Mon, Feb 20, 2017 at 10:16 AM, Shannon Wells-Mongiovi < notifications@github.com> wrote:

ok, if you can please double check that the sparkley offset isn't happening, and merge if it's not, and fix & merge if it is, then let's not make any further changes. We (or I) can figure out the font to use in another branch/PR. [image: bitmoji] https://camo.githubusercontent.com/192cd1de522787e8aa1c515e35ac637a2dab7e9a/68747470733a2f2f72656e6465722e6269747374726970732e636f6d2f76322f6370616e656c2f393933363634392d3133373133363638375f342d73312d76312e706e673f7472616e73706172656e743d312670616c657474653d312677696474683d323436

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shannonwells/clickbait_generator/pull/22#issuecomment-281148693, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaFdAXFq9OynLfApAdFHbVW1lLxJR2Cks5rediRgaJpZM4L3VZM .

bunnymatic commented 7 years ago

double checked with local instance on Firefox/Safari/Chrome. They all looked fine to me. so i merged.

shannonwells / clickbait_generator

Add candy buttons (with sparkle) #22