search

shanraisshan / WhatsApp-Conversation-Menu

Whatsapp conversation attachment menu. Compatible with Android 2.3 (GINGERBREAD - 9) and above.
MIT License
14 stars 4 forks source link

Using deprecated version of Circular Reveal library #1

Open bruneric opened 8 years ago

bruneric commented 8 years ago

According to the author of Circular Reveal library, the version 1.1.1 is now deprecated (because using deprecated android code). The newer versions of his library only support android 4+ now. I would like to know if it's safe to use your Whatsapp Conversation Menu even though it is based on a deprecated version of the Circular reveal library? If not, can you update the Circular Reveal version of your Whatsapp Conversation Menu while trying to maintain it backward compatible with android 2+?

Sorry for my poor english I am French. Thanks for your amazing work!

pedrosoares commented 8 years ago

as we did not get the developer's reply, I correct this error on my fork. https://github.com/pedrosoares/WhatsApp-Conversation-Menu

pedrosoares commented 8 years ago

If the developer wants, he can merge the repos.

bruneric commented 8 years ago

Thanks for your reply pedrosoares. So if I understand well you improved the menu and now the minSdk is android KitKat 15? Please can you tell me if there is a clean and safe trick to use it on android 3+ ? Thanks

pedrosoares commented 8 years ago

Exactly @TheChimeric, now work with API 15 and above, because i Update to the new version of CircularReveal thats use API 15 and above. If you open the Repo in the Android Studio, you gonna see that is easy the implement the menu in your project. If you wanna use old version of API (14 down ) use this Repository, if you wanna 15 and above use the 2.0 version on my repo. Any Questions feel free to ask.