search

shanselman / SmallestDotNet

SmallestDotNet - SmallestDotNet.com is a single page site that does one thing. It tells you the smallest, easiest download you'd need to get the .NET Framework on your system.
MIT License
130 stars 64 forks source link

The code in javascriptdom.ashx could be better in Helpers.cs? #11

Closed shanselman closed 12 years ago

msarchet commented 12 years ago

Are you talking about all of the static checks for versions? That could also probably be added to some kind of lookup instead, and then reused.

shanselman commented 12 years ago

Ya, I'm just noticing that there's a lot of Static Helpers in there and it's duplication of other logic. Just feeling like the whole thing is kind of complex.

I feel like we could simply this a little with some models and workflow (maybe...brainstorming)

UserAgent (string) -> somemethod -> FrameworkModel structure -> someothermethod -> FrameworkMessagesViewModel (has localized text + download links)

On Fri, Sep 21, 2012 at 4:58 PM, Michael Sarchet notifications@github.comwrote:

Are you talking about all of the static checks for versions?

— Reply to this email directly or view it on GitHubhttps://github.com/shanselman/SmallestDotNet/issues/11#issuecomment-8783532.

Scott Hanselman Help me? http://hnsl.mn/fightdiabetes