search

shanselman / SmallestDotNet

SmallestDotNet - SmallestDotNet.com is a single page site that does one thing. It tells you the smallest, easiest download you'd need to get the .NET Framework on your system.
MIT License
130 stars 64 forks source link

Initial work for mobile devices #31

Closed jasonlamb closed 11 years ago

jasonlamb commented 11 years ago

Added iPhone, iPad, iPod, Android, Windows Phone and Windows CE.

I am very inexperienced with Git and GitHub. If I am doing something totally wrong, please let me know and I will correct it. It's also my first collaborative programming attempt since college. If you have any suggestions, please let me know.

shanselman commented 11 years ago

No worries, we can all figure it out together. First, thanks for participating and congrats!

Hey @msarchet - looks like his diff changed a lot (looks like everything) possibly because of a whitespace thing. Are these changes compatible with where you want to go with this? You had that new engine soon...

jasonlamb commented 11 years ago

Thanks!

Yeah, I noticed the LF vs CRLF thing and was curious about that. Do you typically turn off core.autocrlf in git config to alleviate that?

I added some comments to the diffs to make it a little easier to see the changes. Sorry about that!

shanselman commented 11 years ago

That would be a good @msarchet question. My system uses the defaults. Oddly, I have git config --global core.autocrlf FALSE. which I think is technically wrong.

On Fri, Jan 18, 2013 at 11:51 AM, Jason Lamb notifications@github.com wrote:

Thanks!

Yeah, I noticed the LF vs CRLF thing and was curious about that. Do you typically turn off core.autocrlf in git config to alleviate that?

— Reply to this email directly or view it on GitHub.

Scott Hanselman Help me? http://hnsl.mn/fightdiabetes

jasonlamb commented 11 years ago

Cool, mine defaulted to true. I have read mixed views on how it should be set on stackoverflow. It probably should be false with Windows developers. I think the only time it would be an issue set to false is when developers are using a mix of OS X, Linux and Windows. I will change mine to false, do some local testing and wait to see what @msarchet thinks.

Thanks!

msarchet commented 11 years ago

For the core.autocrlf you want it set to true

This just means that git won't change line endings like that for an entire file.

This isn't a problem if everyone has their git set up identically but that isn't a case.

@shanselman I'll just set something up in the attributes for the project so it doesn't matter what people have set.

I'll dig through the changes and take a look at them today/tomorrow.

Thanks @jasonlamb

jasonlamb commented 11 years ago

Thanks for the info @msarchet. I realize I made this change on the master branch. Ideally, should I have created a branch in my fork before the pull request?

Thanks again!!