search

shanselman / SmallestDotNet

SmallestDotNet - SmallestDotNet.com is a single page site that does one thing. It tells you the smallest, easiest download you'd need to get the .NET Framework on your system.
MIT License
130 stars 64 forks source link

Handle unknown releases better #41

Closed binki closed 9 years ago

binki commented 9 years ago

I have .net-4.6 and when I run the tool it just reports that I have .net-4.5. This is misleading and unhelpful because it suggests I have something that is older than .net-4.5.2. Instead, it should say that it scanned “381029” and doesn’t know about it yet.

marcosnz commented 9 years ago

@binki are the changes in my pull request OK?

binki commented 9 years ago

It’s better, but it is hard to find the link being referenced by the text “Please log an issue using the link at the bottom of the page including this information”—the link should probably just be placed like Please <a href="https://github.com/shanselman/SmallestDotNet/issues/">log an issue</a> including this information.

marcosnz commented 9 years ago

Done

binki commented 9 years ago

Nice, that handles much more gracefully than the currently-hosted code. @shanselman, please consider merging this.