shanselman / SmallestDotNet

SmallestDotNet - SmallestDotNet.com is a single page site that does one thing. It tells you the smallest, easiest download you'd need to get the .NET Framework on your system.
MIT License
130 stars 64 forks source link

ReleaseKey=394271 #67

Closed ghost closed 8 years ago

rpetrusha commented 8 years ago

,NET Checker evidently hasn't been updated to support the .NET Framework 4.6.1. The release key for WIndows 10 is 394254, and the key for all other operating systems is 394271. It recognizes neither.

shanselman commented 8 years ago

Adding a Description for this bug...

When someone wants to check what version of the .NET Framework they have, they can use this little utility that they run on their machine. It checks the registry for a number which is the SPECIFIC version of whatever .NET Framework you have. So 4.6 is some number and 4.6.1 is another. Every time a new version comes out we need to update the website with details on where to download it or what it is.

apoorvnandan commented 8 years ago

I tried to reproduce this bug. From what I read in the code of "Program.cs", if the release key is 394271, the program causes the user's default browser to launch and display the url "http://smallestdotnet.com/?releaseKey=394271". On opening this url from my computer, the website says "We Found .NET! The .Net Checker application determined that you have 4.6.1 on your machine. You have 4.6.1, this is a recent version of .NET. Download an installer for the newest version .NET 4.6.1 Web." which is not very different from when I set release key as that of .NET Framework 4.5.1 (378758) as the corresponding url "http://smallestdotnet.com/?releaseKey=378758" says "We Found .NET! The .Net Checker application determined that you have 4.5.1 on your machine."

So, what exactly do you mean by the .NET Checker not recognizing the release keys 394254 and 394271?

shanselman commented 8 years ago

Here is a list of all the release keys. I (or someone) needs to update the app to support and recognize ALL these: https://msdn.microsoft.com/en-us/library/hh925568(v=vs.110).aspx

On Tue, Mar 15, 2016 at 11:00 AM, Apoorv Nandan notifications@github.com wrote:

I tried to reproduce this bug. From what I read in the code of "Program.cs", if the release key is 394271, the program causes the user's default browser to launch and display the url "http://smallestdotnet.com/?releaseKey=394271". On opening this url from my computer, the website says " We Found .NET! The .Net Checker application determined that you have 4.6.1 on your machine. You have 4.6.1, this is a recent version of .NET. Download an installer for the newest version .NET 4.6.1 Web." which is not very different from when I set release key as that of .NET Framework 4.5.1 (378758) as the corresponding url " http://smallestdotnet.com/?releaseKey=378758" says " We Found .NET! The .Net Checker application determined that you have 4.5.1 on your machine."

So, what exactly do you mean by the .NET Checker not recognizing the release keys 394254 and 394271?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/shanselman/SmallestDotNet/issues/67#issuecomment-196950103

Scott Hanselman Donate to fight diabetes: http://hnsl.mn/fightdiabetes

josedusol commented 8 years ago

Shouldn't this be closed?. Also, from what i saw, all the others issues tagged as "first-timers-only" were resolved.