shanselman / SmallestDotNet

SmallestDotNet - SmallestDotNet.com is a single page site that does one thing. It tells you the smallest, easiest download you'd need to get the .NET Framework on your system.
MIT License
130 stars 64 forks source link

Bug Fixes #73

Closed danwissa closed 8 years ago

danwissa commented 8 years ago

Added release keys for .NET 4.6.2 Preview Fix Get.NET link on main page issue: https://github.com/shanselman/SmallestDotNet/issues/60

shanselman commented 8 years ago

Cool! I found a link of those 6 digit numbers here https://msdn.microsoft.com/en-us/library/hh925568(v=vs.110).aspx so maybe we can get a complete list and be totally up to date.

danwissa commented 8 years ago

At a quick glance when I got the 4.6.2 preview keys it looked like the other keys in that link are already there.

I would be happy to take up an activity to cross reference all of them against the code and double check that we are up to date. How does that sound?

Also, any other things I can help with on this project?

On Thu, Apr 7, 2016 at 1:35 PM -0700, "Scott Hanselman" notifications@github.com<mailto:notifications@github.com> wrote:

Cool! I found a link of those 6 digit numbers here https://msdn.microsoft.com/en-us/library/hh925568(v=vs.110).aspx so maybe we can get a complete list and be totally up to date.

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/shanselman/SmallestDotNet/pull/73#issuecomment-207077973

danwissa commented 8 years ago

Just did a cross reference between what we have and the MSDN link, we are totally up to date for everything 4.5 and above. We also have 3 redundant keys now for .NET 4.6 Preview, RC1 & RC2 which no longer show on the site, I guess doesn't hurt to keep them.

Also found that on the latest RedStone build 14316 which I'm currently running, it is using release key 394757 which is currently not in the MSDN link still!

I can add that into the list and submit a new PR, sound good?

shanselman commented 8 years ago

Sure

danwissa commented 8 years ago

Hi Scott, thanks for that. Now done: https://github.com/shanselman/SmallestDotNet/pull/74