Open shanselman opened 9 years ago
Nah, there's always spelling errors to fix! ;)
This particular spelling issue is fixed, I'm sure there are more you can fix, but my pull request was never accepted.
@dvanbale Sorry, was in my spam!
Hi @shanselman I've noticed that there is no consistency on the page with capitalising the words 'Open Source'. There are the following variations in different places:
I know this isn't a big deal, but it might be good to stick to one version. It's my opinion that it shouldn't be capitalised except when it is an acronym (OSS), but perhaps you'd prefer Open Source projects. Either way, I'd be happy to comb through the page and ensure consistency once you let me know what you'd prefer.
Sure!
On Mon, Oct 24, 2016 at 12:46 AM, Jack Lo Russo notifications@github.com wrote:
Hi @shanselman https://github.com/shanselman I've noticed that there is no consistency on the page with capitalising the words 'Open Source'. There are the following variations in different places:
- Open Source
- open source
- Open Source project
- Open Source Project
- OSS (Open Source Software) Project
I know this isn't a big deal, but it might be good to stick to one version. It's my opinion that it shouldn't be capitalised except when it is an acronym (OSS), but perhaps you'd prefer Open Source projects. Either way, I'd be happy to comb through the page and ensure consistency once you let me know what you'd prefer.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shanselman/firsttimersonly/issues/5#issuecomment-255670330, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALTMojoxqLhaFTwQGqQBQfF1Wlc4Hyks5q3GI9gaJpZM4Fo7SG .
Scott Hanselman Donate to fight diabetes: http://hnsl.mn/fightdiabetes
Could i know why my PR was not merged?
Sorry, we were off launching VS for Mac. I was travelling! I'll fix it.
On Sat, Nov 12, 2016 at 7:35 AM, Shreya Bhandare notifications@github.com wrote:
Could i know why my PR was not merged?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shanselman/firsttimersonly/issues/5#issuecomment-260128749, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALTJKh1lfB9lAhvb_lPLTC1-nGA3Fqks5q9dytgaJpZM4Fo7SG .
Scott Hanselman Donate to fight diabetes: http://hnsl.mn/fightdiabetes
Hi @shanselman,
We recommend you follow @yourfirstpr and let them know if your OSS project has a firsttimers only tag and you have open issues that you’ll reserve for a new contributor!
It should be first-timers-only
to make it consistent with other occurrences of this tag on the site. I'd be happy to make this change. It will be my first contribution on github.
Is any help still needed here ?
Submitted pull request 41.
Is there still any need for help with this issue?
I also noticed grammatical issues in the READme and some words that needs to be rephrased for proper communication. Do let me know if I can take that.
I have sent a PR fixing few of the errors.
Hi @shanselman , I have sent a pull request for modifying the ReadMe file to make it more friendly for the new contributors, I hope it adds value to the project.
Hello! Please assign me this issues
Does this mean this issue should be closed?