shanso20 / qbb2023-answers

0 stars 0 forks source link

Bootcamp feedback #1

Open scarioscia opened 1 year ago

scarioscia commented 1 year ago

Day 1: 6/6 1 pt - print out first and last days (exercise 1) 1 pt - calculate averages for all patients (exercise 2) 1 pt - print out first 10 averages (exercise 2) 1 pt - printed out max (exercise 3) 1 pt - printed out min (exercise 3) 1 pt - printed out differences between patients (exercise 4) Try using the .py suffix on your python scripts moving forward so the styling is automatically applied in sublime. Easier for you to troubleshoot, and easier for the TA to review

Day 2: 7/7 1pt - Plot female data 1pt - Add male data 1pt - Plotted two x female data 1 pt x axis label 1 pt y axis label 1 pt labelled each line using a legend 1 pt plot title

Day 3: 6/6 1pt - Submitted mean.py + code looks more or less ok 1pt - Submitted mean_from_file.py + code looks more or less ok 1pt - mean_inflammation.py contains function that calculates mean inflammation 1pt - mean_inflammation.py prints output (or at least function returns the man value) 1pt - difference_inflammation.py contains function that calculates the difference in inflammation 1pt difference_inflammation.py prints output (or at least function returns the man value)

Day 4: 10/10 1 pt - Wright-Fisher function (ex 1) 1 pt - number of generations (ex 1) 1 pt - plot of allele trajectory (ex 1) 1 pt - plot of multiple allele trajectories (ex 2) 1 pt - histogram of time to fixation (ex 2) 1 pt - plot of population size vs time to fixation (ex 3) 1 pt - plot of allele frequency vs time to fixation (ex 3) 3 pts - short written answers to 3 questions (comment on any 3 plots) Gorgeous plots! This was a delight to review. In the future consider more informative script and .png file names (e.g., what is actually happening in the plot rather than day4exercise3 so you can go back to the code in the future if you want to borrow code or review your results

scarioscia commented 1 year ago

Edited day 2 above to reflect addition of legends and uploading of two additional figures. Removed day2 comment "Upload first two plots and add legend to all three plots. Also in the future consider a more descriptive title (e.g., one that includes the gene name)"