search

shantanuraj / podcst-web

Podcast app written in TypeScript using React
https://podcst.app
MIT License
17 stars 2 forks source link

fix(player): Fix toggle playback hotkey overlapping with button activation #53

Closed tcrammond closed 3 years ago

tcrammond commented 3 years ago

What this does

Add more elements to the ignoreKeyboardSelector, allowing SPACE to be used to activate links/buttons/etc. while a podcast is playing. Fixes #50.

I added the most common/obvious possibilities at this time

How to test

  1. Start playing a podcast episode
  2. TAB to something, e.g. the Subscribe button
  3. You can now press SPACE to activate the button, and the podcast won't instead stop/start playing
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shantanu/podcst-web/CAV68d7Xhjmqr1N3xyBsuJ992HYk
✅ Preview: https://podcst-web-git-50-fix-toggle-playback-overlap-hotkey-shantanu.vercel.app