search

shanthisivanesan / ImageSearch

Google ImageSearch
0 stars 0 forks source link

#2 Google Image Search #1

Open shanthisivanesan opened 10 years ago

shanthisivanesan commented 10 years ago

Grid Image Search is an android app for searching images powered by the Google Image Search API. I have extended the Google Image Search to allow a user to modify advanced search options and also incorporated pagination when clicked on more data. Please review. /cc @nesquena @timothy1ee

User Stories Implemented:

1.User can enter a search query that will display a grid of image results from the Google Image API. 2.User can click on "settings" which allows selection of advanced search options to filter results 3.User can configure advanced search filters such as: -Size (small, medium, large, extra-large) -Color filter (black, blue, brown, gray, green, etc...) -Type (faces, photo, clip art, line art) -Site (espn.com) 4.Subsequent searches will have any filters applied to the search results 5.User can tap on any image in results to see the image full-screen 6.User can scroll down “infinitely” to continue loading more image results (up to 8 pages)

Options:

Settings Layout background color Notes: Walkthrough of all user stories.

vibhorB commented 10 years ago

Decent work Shanthi. A few notes after checking out the code:

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

shanthisivanesan commented 10 years ago

Hi Vibhor,

Thanks a lot for reviewing my code in-depth and your feedback.

I checked the logs and seem to have the type getting replaced with the selections made in the settings page. "Photo" is the default value of type, if its not been set.

Attached is the screen shot of the debug log to check if its sending the "line art" and "clip art" selections for type from the settings screen.

Can you let me know if I am missing something?

Thanks Shanthi

On Thu, Jun 19, 2014 at 1:55 AM, vibhorB notifications@github.com wrote:

Decent work Shanthi. A few notes after checking out the code:

  • Type filter is broken, the value selected on UI is line art while type is hard coded to photo. Pls fix this asap and let me know when you have fixed this.
  • Properly reused the single base method in search activity to fetch results for both initial load and the pagination
  • Properly used spinners (with populated values) to allow users to select filters
  • Good work saving settings to SharedPrefs
  • Consider better organizing your source files http://guides.codepath.com/android/Organizing-your-Source-Files

Also, here's a more detailed Project 2 Feedback Guide here https://gist.github.com/nesquena/44091e4727b154d04269 which covers the most common issues with this submitted project. Read through the feedback guide point-by-point https://gist.github.com/nesquena/44091e4727b154d04269 to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

— Reply to this email directly or view it on GitHub https://github.com/shanthisivanesan/ImageSearch/issues/1#issuecomment-46537554 .

Regards Shanthi

'May the whole world enjoy Prosperity, Happiness and Peace' -Vethathiri.

vibhorB commented 10 years ago

Yes I saw that, and it is not highly broken, but when you went to settings page and changed few other filters, I could see the type as lineart, but when you went out of settings, type photo was being applied. A better way of implementing this could be picking whatever is selected when you are saving the settings, instead of changing that only on itemSelectedListener. Since now the current behavior looks broken to me. I hope you got the point I am trying to make. Let me know if you have any questions.

Thanks Vibhor

shanthisivanesan commented 10 years ago

Thanks Vibhor. Sure, I will change it to pick the selected value on save instead of "onitemSelectedListener" and update the code.

On Thu, Jun 19, 2014 at 9:17 AM, vibhorB notifications@github.com wrote:

Yes I saw that, and it is not highly broken, but when you went to settings page and changed few other filters, I could see the type as lineart, but when you went out of settings, type photo was being applied. A better way of implementing this could be picking whatever is selected when you are saving the settings, instead of changing that only on itemSelectedListener. Since now the current behavior looks broken to me. I hope you got the point I am trying to make. Let me know if you have any questions.

Thanks Vibhor

— Reply to this email directly or view it on GitHub https://github.com/shanthisivanesan/ImageSearch/issues/1#issuecomment-46582176 .

Regards Shanthi

'May the whole world enjoy Prosperity, Happiness and Peace' -Vethathiri.

shanthisivanesan commented 10 years ago

HI Vibhor,

Sorry could not get back you as I had class today. I updated the code with the selected items on save and it works fine now.

Thanks Shanthi

On Thu, Jun 19, 2014 at 1:42 PM, Shanthi shanthijayasekar@gmail.com wrote:

Thanks Vibhor. Sure, I will change it to pick the selected value on save instead of "onitemSelectedListener" and update the code.

On Thu, Jun 19, 2014 at 9:17 AM, vibhorB notifications@github.com wrote:

Yes I saw that, and it is not highly broken, but when you went to settings page and changed few other filters, I could see the type as lineart, but when you went out of settings, type photo was being applied. A better way of implementing this could be picking whatever is selected when you are saving the settings, instead of changing that only on itemSelectedListener. Since now the current behavior looks broken to me. I hope you got the point I am trying to make. Let me know if you have any questions.

Thanks Vibhor

— Reply to this email directly or view it on GitHub https://github.com/shanthisivanesan/ImageSearch/issues/1#issuecomment-46582176 .

Regards Shanthi

'May the whole world enjoy Prosperity, Happiness and Peace' -Vethathiri.

Regards Shanthi

'May the whole world enjoy Prosperity, Happiness and Peace' -Vethathiri.