search

shanthisivanesan / TwitterApp

0 stars 0 forks source link

Twitter App for Review #1

Open shanthisivanesan opened 10 years ago

shanthisivanesan commented 10 years ago

My App is complete as mentioned below. Please review. /cc @nesquena @timothy1ee

TwitterClient

Overview: Build a simple Twitter client that supports viewing a Twitter timeline and composing a new tweet.

Completed User Stories:

The following user stories are completed:

1.User can sign in to Twitter using OAuth login

2.User can view the tweets from their home timeline

3.User should be able to see the username, name, body and timestamp for each tweet

4.User should be displayed the relative timestamp for a tweet "8m", "7h"

5.User can view more tweets as they scroll with infinite pagination

6.User can compose a new tweet

7.User can click a “Compose” icon in the Action Bar on the top right

8.User can then enter a new tweet and post this to twitter

8.User is taken back to home timeline with new tweet visible in timeline

Optional and Advanced

9.Optional: User can see a counter with total number of characters left for tweet

10.Advanced: User can tap a tweet to display a "detailed" view of that tweet

vibhorB commented 10 years ago

:+1: Great work Shanthi. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

shanthisivanesan commented 10 years ago

Thanks Vibhor for your comments. I will check your feedback guide for improvements.

Shanthi

On Wed, Jun 25, 2014 at 10:01 PM, vibhorB notifications@github.com wrote:

[image: :+1:] Great work Shanthi. A few notes after checking out the code:

  • Your attention to UI/UX was impressive.
  • Good to see you were able to format the timestamp cleanly
  • Good to see you refreshed the timeline after composing a new tweet
  • Nice touch with the character count being displayed while the user composes a tweet
  • Good to see you added progress bars to your app whenever a network request goes out
  • Consider adding pull to refresh for the home timeline as explained in the cliffnotes
  • Consider adding local persistence of tweets by using ActiveAndroid in the Tweet and User
  • Consider better organizing your source files http://guides.codepath.com/android/Organizing-your-Source-Files

Here's a detailed Project 3 Feedback Guide here https://gist.github.com/nesquena/a41220c54c9550f69599 which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

— Reply to this email directly or view it on GitHub https://github.com/shanthisivanesan/TwitterApp/issues/1#issuecomment-47187935 .

Regards Shanthi

'May the whole world enjoy Prosperity, Happiness and Peace' -Vethathiri.