search

shaoanlu / face_toolbox_keras

A collection of deep learning frameworks ported to Keras for face analysis.
276 stars 87 forks source link

Face parser: unify bounding box coordinates order #6

Open edumucelli opened 4 years ago

edumucelli commented 4 years ago

The face parser has two ways modus operandi:

  1. Using one of the library's detector such as MTCNNFaceDetector or FaceAlignmentDetectoror
  2. Giving a pre-computed bounding box.

However in (1) the coordinates order is y0, x0, y1, x1 (left, top, right, bottom) meanwhile on (2) it is y0, x0, y1, x1 (top, left, bottom,right).

That is very confusing when looking at the code and trying to use it without an internal face detector.

This PR reorders the coordinates and rename them so they are easily understandable.